[14.0][FIX] change membership product on invoice line

[petrus-v]

Description of the issue/feature this PR addresses:

While changing information on invoice line, the related membership line is not updated.

This is done as part of OCA Internal Working Group: task 871862

Current behavior before PR:

• create 2 membership products
• create an invoice with one membership product and save the draft invoice
• (you can see the mebership line is already created with proper information)
• go back to the invoice and use the other product
• 💥 member ship line is not updated

(So, this also happen while duplicating an invoice from previous year changing the membership product.)

Desired behavior after PR is merged:

The member ship line is updated with fresh informations changed on the invoice:

• price
• start /end date (used to compute the membership state)
• ...

[petrus-v]

this seems to be present on version 18.0 as well... I'll propose the patch against Odoo...

[petrus-v]

this seems to be present on version 18.0 as well... I'll propose the patch against Odoo...

but membership module as been refactored to partnership with different business value by this PR odoo#197228 that target version 18.3 so will be removed in future 19.0

[petrus-v]

Please find the upstream PR odoo#211584

[petrus-v]

I've double checked that this fix don't break unittest of vertical-association/membership_extension and membership_delegated_partner_line modules.

[vdewulf]

@petrus-v I tried testing today on runboat but I suppose I miss something in the workflow. Here are the steps I took:

• create 2 membership products, one for 2025 all year, one for 2025 half year (from january to june)
• create an invoice with one membership product and save the draft invoice, the all year membership. Confirm the invoice. (without the confirm of the invoice, there is nothing to see in the members module)
• I can see in the members module one line is with the proper information (start date = today, end-date = 31 December 25)
• go back to the invoice, cancel, reset to draft and update the line of the product to select the half year product. Save and confirm.
• the membership is still showing the previous product, the end date is not updated to 30 June like expected.

So I don't see the fix working.

[petrus-v]

@petrus-v I tried testing today on runboat but I suppose I miss something in the workflow. Here are the steps I took:

* create 2 membership products, one for 2025 all year, one for 2025 half year (from january to june)

* create an invoice with one membership product and save the draft invoice, the all year membership. Confirm the invoice. (without the confirm of the invoice, there is nothing to see in the members module)

* I can see in the members module one line is with the proper information (start date = today, end-date = 31 December 25)

* go back to the invoice, cancel, reset to draft and update the line of the product to select the half year product. Save and confirm.

* the membership is still showing the previous product, the end date is not updated to 30 June like expected.

So I don't see the fix working.

I've seen your tests, I've retry this code on my laptop on a fresh database without issue, I'm wondering if it's related to runboat config on this repository - it's special case comparing to other repository that provide modules- I think I''ve never tested PR here... So it seems we can't tests on runboat here.

as far we are almost ready there OCA/oca-custom#59 I'll:

• add this PR as base for [14.0] OCA' Odoo instance docker image oca-custom#59
• as suggest by @sbidoul I'll remove the undependency check
• launch the release process
• ask an administrator to re animage/create the oca staging environnement based on all this works

So we could get an test environment with OCA context modules!

[petrus-v]

@vdewulf this fix has been deployed to https://test.odoo-community.org, could you retry there?

[petrus-v]

@vdewulf do you have time to gives your review on this one, this one is in production since middle of June!

[thomaspaulb]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1299-by-thomaspaulb-bump-patch, awaiting test results.

[petrus-v]

@thomaspaulb it's not clear to me why bot is still merging for a month 😿 ?

[thomaspaulb]

@petrus-v I think in OCB we're not supposed to use the bot but just merge directly

@pedrobaeza Just a check before I break something: can I just press merge? Or does Pierre need to rebase first?

[pedrobaeza]

This can't be merged, as this is changing things a way that a module using this hook won't be compatible with both vanilla Odoo and OCB. Anyway, you are already migrating OCA instance to 18, so just keep your patch locally, and push this hook in vanilla Odoo 18.