[16.0] Python 3.13 / Debian Trixie compatibility #1321
Draft
+38
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part-of: odoo#219270 Related: odoo/enterprise#90352 Signed-off-by: Xavier Morel (xmo) <[email protected]>
Werkzeug 3.0 deprecated `werkzeug.__version__` and 3.1 removed it. Trixie bundles werkzeug 3.1.3. So use `importlib.metadata.version` to retrieve the package's version. It was made final (non-provisional) in Python 3.10 which is the minver for odoo 17 so no need for a conditional. Also remove the unnecessary fallback in `test_misc`. Part-of: odoo#219270 Related: odoo/enterprise#90352 Signed-off-by: Xavier Morel (xmo) <[email protected]>
Some libraries need to be bumped to be compatible with Python 3.13 (as used in Trixie). In that case we update the requirements to the Trixie version if possible, even if a lower version would be compatible with 3.13 itself. - babel needs to be at least [2.11 to avoid usage of cgi][2] removed from 3.13 - freezegun needs to be [at least 1.5.0][3] to not call the now-removed `uuid._load_system_functions()` - trixie ships gevent 24.11.1 and greenlet 3.1.0, but upstream [gevent 24.11.1 requires greenlet 3.1.1][1] so basing the requirements off of trixie doesn't even install - zeep needs to be [at least 4.3.0][4] to not use the `cgi` module [1]: https://github.com/gevent/gevent/blob/24.11.1/setup.py#L200-L214 [2]: https://babel.pocoo.org/en/latest/changelog.html#version-2-11-0 [3]: spulec/freezegun#534 [4]: mvantellingen/python-zeep#1364 Part-of: odoo#219270 Related: odoo/enterprise#90352 Signed-off-by: Xavier Morel (xmo) <[email protected]>
OrderedMultiDict is deprecated in Werkzeug 3.1 (pallets/werkzeug#2975) which is what Trixie bundles. While the entire thing was straight up removed in 5229cc8, pretty much keep the semantics by more or less inlining the way OrderedMultiDicts are compared. Part-of: odoo#219270 Related: odoo/enterprise#90352 Signed-off-by: Xavier Morel (xmo) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Partial backport of odoo#219270
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr