Skip to content

[14.0][IMP] openupgrade_framework: remove FKs of obsolete tables/columns #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiquelRForgeFlow wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] openupgrade_framework: remove FKs of obsolete tables/columns #2989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from openupgradelib import openupgrade

from odoo import api, models
from odoo import api, models, tools
from odoo.tools import mute_logger

from odoo.addons.base.models.ir_model import (
Expand All @@ -17,7 +17,11 @@
def _drop_table(self):
"""Never drop tables"""
for model in self:
if self.env.get(model.model) is not None:
current_model = self.env.get(model.model)
if current_model is not None:
table = current_model._table
if tools.table_kind(self._cr, table) == "r":
openupgrade.remove_tables_fks(self.env.cr, [table])
openupgrade.message(
Copy link
Member

@pedrobaeza pedrobaeza Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can mention on the message that only removing FKs, but it's optional.

Copy link
Member

@pedrobaeza pedrobaeza Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow let's finish this putting that message.

self.env.cr,
"Unknown",
Expand All @@ -36,6 +40,15 @@ def _drop_column(self):
for field in self:
if field.name in models.MAGIC_COLUMNS:
continue
model = self.env.get(field.model)
if (
field.store
and field.ttype == "many2one"
and model is not None
and tools.column_exists(self._cr, model._table, field.name)
and tools.table_kind(self._cr, model._table) == "r"
):
openupgrade.lift_constraints(self.env.cr, model._table, field.name)
openupgrade.message(
self.env.cr,
"Unknown",
Expand Down