[17.0][OU-IMP]hr: Add computation of some fields

[etobella]

Otherwise, an error might be rise if we have hr_holidays_natural_period installed because the option might have not been selected yet.

[etobella]

@MiquelRForgeFlow May I ask for your opinion? 🙏

[MiquelRForgeFlow]

Hehe An alternative should be adding migration scripts in hr_holidays_natural_period, by recomputing those fields...

[etobella]

The problem is that the compute is failing because it has a value that doesn't exist yet

[MiquelRForgeFlow]

LGTM

[pedrobaeza]

My concern on this is the increase of time on the execution, or to have different data in past leaves. Why are you recomputing the duration? Remember that you may adjust manually the duration. I don't think it should be recomputed.

[etobella]

After a full review of the error I found that the problem comes from the fact that number_of_hours was not stored in v16, but stored in v17. If we don't apply something, the function is executed no matter what, and it might raise errors if we have other modules like natural_days.

Options I see:

• Create the field and leave it blank (reexecute only for the leaves needed?)
• Reexecute for everyone as we did it before but on the end-migration, to ensure that other changes will work.

Leaving as it is will not work if you are using an OCA module and there is no natural way to solve it.

[pedrobaeza]

I agree on pre-adding the field, but we shouldn't trigger the regular computation, as that one computes both number_of_days and number_of_hours, overwriting manual changes done on number_of_days field.

[etobella]

legit for me. I will manage it

[pedrobaeza]

@etobella do you plan to add anything more?

[etobella]

@pedrobaeza no, I think I made all the changes that you asked for.

[pedrobaeza]

Suggested change

	# Pre-migration script and end-migration script to recompute
	# DONE: pre-migration: add column for avoiding the computation