Skip to content

[18.0][MIG] brand_external_report_layout #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bosd wants to merge 50 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] brand_external_report_layout #224

bosd wants to merge 50 commits into from

Conversation

@bosd
Copy link
Contributor

@bosd bosd commented Feb 10, 2025 •
edited
Loading

depends upon: #217

@bosd bosd marked this pull request as ready for review February 10, 2025 20:39
@bosd bosd mentioned this pull request Feb 10, 2025
Open
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from 6501083 to c0c083b Compare February 22, 2025 14:32
@bosd bosd mentioned this pull request Feb 22, 2025
Closed
@bosd bosd mentioned this pull request Mar 11, 2025
Open
17 tasks
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from c0c083b to 9e5ae8f Compare April 2, 2025 10:28
@bosd bosd mentioned this pull request Apr 2, 2025
Open
@max3903 max3903 added this to the 18.0 milestone Apr 9, 2025
@marielejeune
Copy link
Contributor

marielejeune commented Apr 14, 2025

Hi, could you please rebase to include changes made in v16 here: #238 ? Thanks

@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch 2 times, most recently from 7132659 to e281fda Compare April 14, 2025 16:52
@bosd
Copy link
Contributor Author

bosd commented Apr 14, 2025

@marielejeune Done, Can you please review?

@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch 2 times, most recently from 4111e15 to 04f5174 Compare April 14, 2025 17:06
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from 04f5174 to df9078a Compare April 15, 2025 08:15
@bosd bosd requested a review from marielejeune April 15, 2025 08:21
@robotiko
Copy link

robotiko commented May 24, 2025

Hi,
Folder layout doesn't show header and color style options.
The rest of layouts seem to be ok.

@yvaucher
Copy link
Member

yvaucher commented Jul 29, 2025

/ocabot migration brand_external_layout

yvaucher
yvaucher approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvaucher
Copy link
Member

yvaucher commented Jul 29, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 29, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 29, 2025
@OCA-git-bot
Merge PR #224 into 18.0
8e239a6 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 29, 2025

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

badbole and others added 26 commits December 21, 2025 18:25
@badbole
Added translation using Weblate (Croatian)
6130ecc
[UPD] Update brand_external_report_layout.pot
fdee6bc
@weblate
Update translation files
c27f393 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/
@ibuioli
Added translation using Weblate (Spanish (Argentina))
fbcc75c
@Ivorra78
Added translation using Weblate (Spanish)
d9c439a
@OCA-git-bot
[UPD] README.rst
e666b5d
@weblate
Update translation files
22954e4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/
@Sibert-Aerts
[FIX] Add missing sudo() in template
22263d9
@OCA-git-bot
[BOT] post-merge updates
d6542c6
@mymage
Added translation using Weblate (Italian)
fb6e509
@bosd
Added translation using Weblate (Dutch)
1a8ff1a
@adasatorres
[REF]brand_external_report_layout: header and footer as Html field
cfe1388
@antonioburic
[IMP] brand_external_report_layout: apply pre-commit auto fixes
b62b458
@antonioburic
[MIG] brand_external_report_layout: Migration to 17.0
fdd7031
@RemiFr82
[ADD] is_company_detail_empty Boolean on res.brand
0ba60c2 
The field works like on res.company model

[FIX] add missing import

[IMP] formatting
@sbejaoui @bosd
[FIX] fix typo in remade
4c1eee7 
Co-authored-by: bosd <[email protected]>
@bosd
[IMP] brand_external_report_layout: pre-commit auto fixes
bbef997
@bosd
[MIG] brand_external_report_layout: Migration to 18.0
26a9643
@bosd
[CLEAN]brand_external_report_layout: Remove unused scss references
42e09b3
@bosd
[IMP] brand_external_report_layout: update fonts
6270448
@bosd
[IMP]brand_external_report_layout: UI similar to Core
c2f63df
@bosd
[IMP]brand_external_report_layout: Update layouts
dc7b72c
@bosd
[REM]brand_external_report_layout: Remove geomatric background
bf9e152
@bosd
[IMP]brand_external_report_layout: Add unit tests
e564809
@jguenat
[FIX] brand_external_report_layout: asset is required to have brand s…
7f89f15 
…tyle in the report
@jguenat
[FIX] brand_external_report_layout: is_html_empty missing for boxed a…
a89ef90 
…nd bold template rendering
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from 66545d0 to a89ef90 Compare December 21, 2025 17:26
@bosd
Copy link
Contributor Author

bosd commented Dec 21, 2025

:green: ✨

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 21, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yvaucher yvaucher yvaucher approved these changes

+2 more reviewers

@astirpe astirpe astirpe approved these changes

@marielejeune marielejeune marielejeune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved migration needs review ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.