[18.0][MIG] partner_brand: Migration to 18.0 #232
Conversation
|
@BhaveshHeliconia Can you remove the test dependencies on this one? |
|
@bosd, I removed test file.Please review the PR when you get a chance. |
bosd
left a comment
bosd
left a comment
There was a problem hiding this comment.
Functional review :+1
Please drop the last 2 commits. Test requirements does'nt have to be in the history.
Nit picking: Demo data should be moved to the demo folder.
Pre-approving.
|
This PR has the |
There was a problem hiding this comment.
I think a missing piece in the brand repo is the ability to select a brand on a partner.
Then when a sale order is made, the quotation/SO is branded according to the brand set on the partner.
(Edit: Made #257)
This module add the fields the field to the partner module. But looks like it serves a different purpose.
IMO would love to have this module to be more neutral without the added (r) sign.
There was a problem hiding this comment.
We could inherit here from the mixing of the base module.
In that way the setting of the brand_use_level will be respected by this module.
|
/ocabot migration partner_brand |
|
@BhaveshHeliconia Can you rebase? The requirement is not needed anymore. |
Currently translated at 100.0% (5 of 5 strings) Translation: brand-16.0/brand-16.0-partner_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-partner_brand/es/
Currently translated at 100.0% (5 of 5 strings) Translation: brand-16.0/brand-16.0-partner_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-partner_brand/it/
BhaveshHeliconia
force-pushed
the
18.0-mig-partner_brand
branch
from
8773765 to
a7bbdde
Compare
|
@yvaucher : It's Done. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 345fb43. Thanks a lot for contributing to OCA. ❤️ |
9 participants
Depends on #217