[18.0][MIG] connector_importer_source_sftp: Migration to 18.0 #172

yankinmax · 2025-10-24T10:47:09Z

No description provided.

yankinmax · 2025-10-29T17:45:05Z

Hello @simahawk @sebalix @SilvioC2C can you pls help with any suggestions?
I'm not familiar with the module usage.
My debug session shows that filelist = self.list(relative_path) is empty, so no files are really found.
https://github.com/OCA/storage/blob/5bbfe12c01e68e562922838aa5fd0eb28dc235a0/storage_backend/components/base_adapter.py#L32

yankinmax · 2025-10-30T07:57:06Z

Hello @simahawk @sebalix @SilvioC2C can you pls help with any suggestions? I'm not familiar with the module usage. My debug session shows that filelist = self.list(relative_path) is empty, so no files are really found. https://github.com/OCA/storage/blob/5bbfe12c01e68e562922838aa5fd0eb28dc235a0/storage_backend/components/base_adapter.py#L32

So, the issue is definitely with the _selection_source_ref_id override to include import.source.csv.sftp source.
It's not called somehow 😢

https://github.com/OCA/connector-interfaces/pull/172/files#r2476825551

yankinmax · 2025-10-30T08:23:59Z

connector_importer_source_sftp/models/source_mixin.py

+    def _selection_source_ref_id(self):
+        selection = super()._selection_source_ref_id()
+        new_source = ("import.source.csv.sftp", "CSV SFTP")
+        if new_source not in selection:
+            selection.append(new_source)
+        return selection


this is not working as expected

yankinmax · 2025-11-03T16:59:20Z

connector_importer_source_sftp/models/__init__.py

@@ -1,2 +1,2 @@
-from . import source_csv_sftp
 from . import source_mixin
+from . import source_csv_sftp


@ivantodorovich this idea didn't help

ivantodorovich · 2025-11-03T17:52:44Z

connector_importer_source_sftp/models/source_csv_sftp.py

+
+    _name = "import.source.csv.sftp"
+    _inherit = [
+        "import.source.csv",


try also inheriting from the mixin again here

Suggested change

"import.source.csv",

"import.source.csv",

"import.source.consumer.mixin",

@ivantodorovich something really unexpected happening here. Seems still not working as expected. I wonder if we could adapt to use fields.Selection here?

Yes, simplify if needed.

Making source_model selection attribute as usual list of tuples and adding to the inherited class selection_add also doesn't work.

@simahawk @sebalix do you have any idea of the issue that _selection_source_ref_id override doesn't actually add new_source, simply not called.

connector_importer_source_sftp/models/source_mixin.py

@api.model def _selection_source_ref_id(self): selection = super()._selection_source_ref_id() new_source = ("import.source.csv.sftp", "CSV SFTP") if new_source not in selection: selection.append(new_source) return selection

A file can be moved only if we have a destination path.

Instead of throwing an exception with an unclear message in the _get_line function

yankinmax · 2025-11-06T15:52:35Z

Thanks for help @ivantodorovich 🙏

Traceback: ``` File ".../connector_importer_source_sftp/components/event_listeners.py", line 32, in _skip_move_file source = importer.recordset.get_source() File ".../connector_importer/models/sources/source_consumer_mixin.py", line 71, in get_source return self.source_ref_id File "/opt/odoo/odoo/fields.py", line 1303, in __get__ self.compute_value(recs) File "/opt/odoo/odoo/fields.py", line 1485, in compute_value records._compute_field_value(self) File "/opt/odoo/odoo/models.py", line 5297, in _compute_field_value fields.determine(field.compute, self) File "/opt/odoo/odoo/fields.py", line 110, in determine return needle(*args) File ".../connector_importer/models/sources/source_consumer_mixin.py", line 43, in _compute_source_ref_id item.source_ref_id = f"{item.source_model},{item.source_id}" File "/opt/odoo/odoo/fields.py", line 1398, in __set__ self.write(protected_records, value) File "/opt/odoo/odoo/fields.py", line 1205, in write cache_value = self.convert_to_cache(value, records) File "/opt/odoo/odoo/fields.py", line 3041, in convert_to_cache raise ValueError("Wrong value for %s: %r" % (self, value)) ValueError: Wrong value for import.recordset.source_ref_id: 'import.source.csv.sftp,1' ``` For some reason I don't know, by the time the event listener skip_if condition is evaluated, the `import.recordset` model does not have applied the override to `_selection_source_ref_id` in the mixin, and so the Reference field fails with this ValueError. The workaround here makes `get_source` not actually use the Reference field, but directly `source_model` and `source_id`, which of course do not attempt to validate the value.

… tests For some reason, probably due to server_environment, if tests are ran during the module installation, like in the oca-ci, the storage backend_type is "filesystem", when it should be "sftp" according to the demo data. Did not investigate any further.

…le not found

ivantodorovich · 2025-12-02T13:45:37Z

@simahawk this one's ready too

simahawk · 2025-12-02T14:17:28Z

/ocabot merge nobump

OCA-git-bot · 2025-12-02T14:17:35Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-172-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-12-02T14:21:55Z

Congratulations, your PR was merged at 947f1ac. Thanks a lot for contributing to OCA. ❤️

Add connector_importer_source_sftp

214fa58

yankinmax mentioned this pull request Oct 24, 2025

Migration to version 18.0 #145

Open

1 task

yankinmax force-pushed the 18.0-mig-connector_importer_source_sftp branch from ae11221 to 4c59328 Compare October 24, 2025 11:01

yankinmax marked this pull request as draft October 27, 2025 08:02

yankinmax commented Oct 30, 2025

View reviewed changes

yankinmax commented Nov 3, 2025

View reviewed changes

ivantodorovich reviewed Nov 3, 2025

View reviewed changes

yankinmax force-pushed the 18.0-mig-connector_importer_source_sftp branch from 982071a to 902dfd5 Compare November 3, 2025 18:07

simahawk and others added 5 commits November 6, 2025 09:15

connector_importer_source_sftp: migrate to v14

295f292

c_importer_source_sftp: fix move file

8693d89

A file can be moved only if we have a destination path.

[MIG] connector_importer_source_sftp: Migration to 15.0

9a7688c

[IMP] connector_importer_source_sftp: Handle no or empty file found case

8a5a264

Instead of throwing an exception with an unclear message in the _get_line function

connector_importer_source_sftp: fix pin cryptography<37

0814160

ivantodorovich force-pushed the 18.0-mig-connector_importer_source_sftp branch from 902dfd5 to 7ee25ea Compare November 6, 2025 12:58

[MIG] connector_importer_source_sftp: Migration to 18.0

64b8b25

ivantodorovich force-pushed the 18.0-mig-connector_importer_source_sftp branch 2 times, most recently from f63f2f0 to 6db6bd8 Compare November 6, 2025 14:35

ivantodorovich approved these changes Nov 6, 2025

View reviewed changes

yankinmax marked this pull request as ready for review November 6, 2025 15:51

ivantodorovich added 3 commits November 19, 2025 12:39

[IMP] connector_importer_source_sftp: properly raise exceptions if fi…

91c1be3

…le not found

ivantodorovich force-pushed the 18.0-mig-connector_importer_source_sftp branch from 6db6bd8 to 91c1be3 Compare November 19, 2025 15:43

OCA-git-bot added the bot is merging ⏳ label Dec 2, 2025

OCA-git-bot merged commit 0724592 into OCA:18.0 Dec 2, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 2, 2025

	"import.source.csv",
	"import.source.csv",
	"import.source.consumer.mixin",

Uh oh!

[18.0][MIG] connector_importer_source_sftp: Migration to 18.0 #172

[18.0][MIG] connector_importer_source_sftp: Migration to 18.0 #172

Uh oh!

Conversation

yankinmax commented Oct 24, 2025

Uh oh!

yankinmax commented Oct 29, 2025

Uh oh!

yankinmax commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yankinmax Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yankinmax Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Nov 6, 2025

Uh oh!

ivantodorovich commented Dec 2, 2025

Uh oh!

simahawk commented Dec 2, 2025

Uh oh!

OCA-git-bot commented Dec 2, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yankinmax commented Oct 30, 2025 •

edited

Loading

yankinmax Nov 4, 2025 •

edited

Loading