[18.0] [FIX] connector_importer: use the original value for the unique key if not mapped

[ivantodorovich]

Using options like this:

- model: res.country
  options:
    importer:
      odoo_unique_key: id
      override_existing: false
      break_on_error: true
    mapper:
      name: importer.mapper.dynamic

And a sample file like this:

id;code;name
base.af;AF;Afghanistan

  File ".../connector-interfaces/connector_importer/models/record.py", line 94, in import_record
    return importer.run(
           ^^^^^^^^^^^^^
  File ".../connector-interfaces/connector_importer/components/importer.py", line 355, in run
    skip_info = self.skip_it(values, line)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../connector-interfaces/connector_importer/components/importer.py", line 237, in skip_it
    msg += f": {self.unique_key}={values[self.unique_key]}"
                                  ~~~~~~^^^^^^^^^^^^^^^^^
KeyError: 'id'

[OCA-git-bot]

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

[simahawk]

any chance to have updated tests? 😁

[ivantodorovich]

I didn't find my way into the existing tests :/
anyway it's only for the skip message, so not a big deal IMO

[simahawk]

I didn't find my way into the existing tests :/ anyway it's only for the skip message, so not a big deal IMO

The test is here https://github.com/OCA/connector-interfaces/blob/18.0/connector_importer/tests/test_record_importer.py#L76

The mapper here https://github.com/OCA/connector-interfaces/blob/18.0/connector_importer/tests/fake_components.py#L8

You could simply add a ref key in the source and have an empty id key. This should lead to the situation you are trying to fix.

[ivantodorovich]

Unit test added.
Ok to merge, @simahawk ? 🙏🏻

[simahawk]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-175-by-simahawk-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 33a5f31. Thanks a lot for contributing to OCA. ❤️