[18.0] [IMP] connector_importer: handle empty values in dynamicmapper #177
+81
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @simahawk, |
ivantodorovich
force-pushed
the
18.0-imp-dynamic-mapper-empty-value
branch
from
18a0b3c to
bf27251
Compare
Empty values in the source must be treated as `False` to be aligned with Odoo's ORM. For example, 'ref': '' must be treated as `False`, which translates to a NULL value in the database. Otherwise, the value is set to an empty string, which is a bit unexpected by the ORM, and may cause unexpected behaviors like UNIQUE constraint violations, usually not possible to reproduce with standard Odoo's flows.
…e_id The new warning caught this silent error, so this fixes it. ``` WARNING odoo [importer]: Field `title_id` not found in model `res.partner` ```
ivantodorovich
force-pushed
the
18.0-imp-dynamic-mapper-empty-value
branch
from
bf27251 to
a231a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty values in the source must be treated as
Falseto be aligned with Odoo's ORM.For example, 'ref': '' must be treated as
False, which translates to a NULL value in the database.Otherwise, the value is set to an empty string, which is a bit unexpected by the ORM, and may cause unexpected behaviors like UNIQUE constraint violations, usually not possible to reproduce with standard Odoo's flow