-
-
Notifications
You must be signed in to change notification settings - Fork 331
[14.0][MIG] edi purchase edifact oca #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
[14.0][MIG] edi purchase edifact oca #1144
Conversation
|
For me locally the unit test I'm not sure whether the ASCII coded umlaut is a valid case or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me locally the unit test test_action_confirm() is failing in last assertion.
Hi @mathiasfrancke,
This issue was caused by my mistake, as I only tested with ASCII characters, while the encoding used by edi.exchange.type is ISO-8859-1.
You can fix this by applying the changes I suggested. The same fix should be applied in a few other similar places as well.
If you need anything, feel free to tag me 😉
| self.partner_2 = self.env.ref("base.res_partner_12") | ||
| self.exc_type_input = self.env.ref( | ||
| "edi_purchase_edifact_oca.edi_exchange_type_purchase_order_input" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ) | |
| ) | |
| self.exc_type_output = self.env.ref("edi_purchase_edifact_oca.edi_exchange_type_purchase_order_out") | |
| self.assertEqual( | ||
| exchange_record.exchange_file, b64encode(expected_data.encode()) | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| self.assertEqual( | |
| exchange_record.exchange_file, b64encode(expected_data.encode()) | |
| ) | |
| self.assertEqual( | |
| exchange_record.exchange_file, b64encode(expected_data.encode(self.exc_type_output.encoding))) |
f4c8442 to
3400bd7
Compare
…default_code from product.supplierinfo
3400bd7 to
1527e24
Compare
…. Convert to a propery UoM
854e8dc to
d850245
Compare
…e correct exchange type
c3a4fb3 to
44679d3
Compare
No description provided.