Skip to content

[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NICO-SOLUTIONS wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality #1116

NICO-SOLUTIONS wants to merge 1 commit into from
+24 −17

Conversation

@NICO-SOLUTIONS
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS commented Jul 2, 2025

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review July 2, 2025 13:14
ioans73
ioans73 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@ioans73 ioans73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NICO-SOLUTIONS
[IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality
5368132 
- replace banner.js with new consent.js script using domain and identifier
- remove www. prefix from domain in cookiefirst script URL
- back ported from V17 PR (OCA#1110 & OCA#1117)
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 14.0-bp-imp-website_cookiefirst_consent_js branch from ef79780 to 5368132 Compare July 10, 2025 10:01
mariancuadranetkia
mariancuadranetkia approved these changes Aug 20, 2025
View reviewed changes
Copy link

@mariancuadranetkia mariancuadranetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 20, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ioans73 ioans73 ioans73 approved these changes

@miguel-S73 miguel-S73 miguel-S73 approved these changes

@mariancuadranetkia mariancuadranetkia mariancuadranetkia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NICO-SOLUTIONS @OCA-git-bot @ioans73 @miguel-S73 @mariancuadranetkia