Skip to content

Conversation

@rousseldenis
Copy link

@rousseldenis rousseldenis commented May 22, 2025

Supersedes : #938 (rebased on new code)

Includes several improvements:

  • [IMP] stock_storage_type: Use of AND() instead of appending domains
  • [IMP] stock_storage_type: Rely on ORM in order to get locations
  • [IMP] stock_storage_type: Remove unused test file
  • [REF] stock_storage_type: Rely on stock_location_fill_state for empty state
  • [IMP] stock_storage_type: Ensure that a being emptied location can be filled in

… been populated

    In the case of no product mixing, if a destination location has already been computed and
    in the meantime, the location has been populated by another product, the computation
    still propose the same location.

    Exclude locations in that case.
…uantity

    The current implementation was triggerring queries (read_group). Rely now
    on ORM to get records as 'quant_ids' field exists on locations
@OCA-git-bot
Copy link
Contributor

Hi @jbaudoux,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added enhancement New feature or request needs review labels May 22, 2025
@rousseldenis
Copy link
Author

@jbaudoux

@rousseldenis rousseldenis added this to the 16.0 milestone May 22, 2025
@rousseldenis rousseldenis changed the title [16.0][IMP] stock_storage_type: Allow to recompute putaways [16.0][IMP] stock_storage_type: Allow to recompute putaways + several improvements May 22, 2025
@rousseldenis rousseldenis force-pushed the 16.0-imp-allow-to-recompute-putaways-dro branch from 0e0aa56 to 0d1b526 Compare May 22, 2025 13:34
… filled in

If every possible destination location (e.g.: for pickable stock) is filled in with
products, but with one outgoing move is in progress (picked but not yet validated),
the location should become available to store incoming products.

The putaway strategy should propose that location. So, add a condition to select 'empty' and
'being emptied' locations along with the 'location_will_contain_product/lot_ids' property to
avoid too much restriction
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jbaudoux
Copy link
Contributor

FYI @sebalix

@jbaudoux
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1040-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 14, 2025
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1040-by-jbaudoux-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants