[16.0][IMP] stock_storage_type: condition context #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @rousseldenis, |
jbaudoux
changed the title
Contributor
Author
|
Need review here @rousseldenis @sebalix |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sebalix
added
no stale
Give in evaluation context what is being moved
jbaudoux
force-pushed
the
16-stock_storage_type-cond_var
branch
from
a582d80 to
cb2c00f
Compare
Contributor
Author
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give in evaluation context what is being moved
cc @rousseldenis
Evaluating the condition on the quant does not represent what is being moved as I can move only a partial quantity. I need the quantity being moved to see if it fit the destination location.