Skip to content

Conversation

@DongilMin
Copy link
Member

@DongilMin DongilMin commented Aug 22, 2025

Summary by CodeRabbit

  • 신규 기능
    • 친구 초대 메시지가 풍부한 메타데이터를 포함하도록 개선되었습니다.
      • 표시 항목: 방 이름, 비공개 여부, 방장 닉네임/프로필 이미지/인기도, 현재 인원/최대 인원, 영상 제목/썸네일/재생시간, 초대 메시지
      • 초대 DM에서 더 풍부한 미리보기와 문맥 정보를 제공해, 입장 전 필요한 정보를 한눈에 확인할 수 있습니다.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

inviteFriendToRoom에서 초대 DM 본문을 기존의 단순 문자열 대신, 방/호스트/영상 메타데이터를 포함한 contentObj(JSON)로 구성하여 저장하도록 변경되었습니다. contentObj에는 roomId, roomName, hostNickname, hostProfileImage, hostPopularity, currentParticipants, maxParticipants, videoTitle, videoThumbnail, duration, isPrivate, message 등이 포함되며, 영상 관련 필드는 없을 경우 빈 문자열로 대체됩니다. 알림 생성, 초대자/영상 조회, Socket.IO 전송 구조와 흐름은 그대로 유지됩니다. 공개된/내보내는 API 시그니처 변경은 없습니다.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant FS as FriendService
  participant DB as DB (Room/Host/Video)
  participant NS as NotificationService
  participant DMS as DirectMessageService
  participant SIO as Socket.IO
  participant R as Recipient

  C->>FS: inviteFriendToRoom(request)
  FS->>DB: Fetch room, host, video
  DB-->>FS: room, host, video
  note over FS: contentObj 생성<br/>- room/host/video 메타데이터 수집<br/>- message 포함<br/>- 누락 시 기본값 처리

  FS->>NS: Create notification (invite)
  NS-->>FS: notificationId

  FS->>DMS: Save DM with content = JSON.stringify(contentObj)
  DMS-->>FS: dmId

  FS->>SIO: Emit invite payload (includes JSON content)
  SIO-->>R: Receive invite

  FS-->>C: Return result (notification, dm)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 10d0929 and 7b974b2.

📒 Files selected for processing (1)
  • src/services/friendServices.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DongilMin DongilMin merged commit 9e5fa99 into ON-AIR-mate:main Aug 22, 2025
1 of 2 checks passed
@ekdbss ekdbss changed the title Fix: 방초대 1ㄷ1 dm 수정 Fix: 방 초대 1대1 dm 수정 Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant