-
Notifications
You must be signed in to change notification settings - Fork 4
Fix: 방 초대 1대1 dm 수정 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 방 초대 1대1 dm 수정 #134
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughinviteFriendToRoom에서 초대 DM 본문을 기존의 단순 문자열 대신, 방/호스트/영상 메타데이터를 포함한 contentObj(JSON)로 구성하여 저장하도록 변경되었습니다. contentObj에는 roomId, roomName, hostNickname, hostProfileImage, hostPopularity, currentParticipants, maxParticipants, videoTitle, videoThumbnail, duration, isPrivate, message 등이 포함되며, 영상 관련 필드는 없을 경우 빈 문자열로 대체됩니다. 알림 생성, 초대자/영상 조회, Socket.IO 전송 구조와 흐름은 그대로 유지됩니다. 공개된/내보내는 API 시그니처 변경은 없습니다. Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant FS as FriendService
participant DB as DB (Room/Host/Video)
participant NS as NotificationService
participant DMS as DirectMessageService
participant SIO as Socket.IO
participant R as Recipient
C->>FS: inviteFriendToRoom(request)
FS->>DB: Fetch room, host, video
DB-->>FS: room, host, video
note over FS: contentObj 생성<br/>- room/host/video 메타데이터 수집<br/>- message 포함<br/>- 누락 시 기본값 처리
FS->>NS: Create notification (invite)
NS-->>FS: notificationId
FS->>DMS: Save DM with content = JSON.stringify(contentObj)
DMS-->>FS: dmId
FS->>SIO: Emit invite payload (includes JSON content)
SIO-->>R: Receive invite
FS-->>C: Return result (notification, dm)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit