Skip to content

Conversation

@duprijil
Copy link
Collaborator

@duprijil duprijil commented May 26, 2025

Changes DAGs instance's finish status based on internal behaviour.

  • notice_processing_dag will not fail if all notices are INELIGIBLE_FOR_TRANSFORMATION
  • fetch_notices_by_date, load_mapping_suite have now hard fail behaviour
  • fetch_by_date DAG now does not start scheduled run when enabling first time

@duprijil duprijil requested a review from Dragos0000 May 26, 2025 06:26
@duprijil duprijil self-assigned this May 26, 2025
@duprijil duprijil added the enhancement New feature or request label May 26, 2025
@duprijil duprijil changed the base branch from develop to feature/SWS2-18 May 27, 2025 20:12
Base automatically changed from feature/SWS2-18 to develop May 27, 2025 20:33
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 51.51515% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@726ac53). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dags/operators/DagBatchPipelineOperator.py 30.76% 9 Missing ⚠️
...processor/services/conceptual_mapping_processor.py 20.00% 4 Missing ⚠️
dags/pipelines/notice_fetcher_pipelines.py 0.00% 2 Missing ⚠️
dags/notice_processing_pipeline.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #585   +/-   ##
==========================================
  Coverage           ?   92.75%           
==========================================
  Files              ?      123           
  Lines              ?     6304           
  Branches           ?        0           
==========================================
  Hits               ?     5847           
  Misses             ?      457           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@duprijil duprijil marked this pull request as ready for review May 28, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants