CSLC: use scipy for computing coherence #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update packages in environment.yml
Update nodejs in environment.yml, as earlier version (14.18.3) is not supported on the Mac M1.
Landslide example
Fix minor spelling typo.
Removing conflict with main
…ic-plots Notebook and sample plots of HLS and DSWx over Lake Mead
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
scottstanie
added a commit
to scottstanie/dolphin
that referenced
this pull request
Jan 31, 2024
See OPERA-Cal-Val/OPERA_Applications#35 `uniform_filter` seems to run faster for all input/filter sizes.
scottstanie
added a commit
to isce-framework/dolphin
that referenced
this pull request
Jan 31, 2024
* Deprecate `moving_window_mean` in favor of `uniform_filter` See OPERA-Cal-Val/OPERA_Applications#35 `uniform_filter` seems to run faster for all input/filter sizes. * call `nearest` for mode, now there are not as obvious edge effects
|
Not sure if I thought the other numpy way was faster or what, but thanks for pointing this out @johntruckenbrodt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled across this. Using
scipy.ndimage.uniform_filtershould be more performant than the custom functioncslc_utils.moving_window_mean. The results are nearly identical.