Allow for choice of notebook root #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Aug 20, 2025
| working_dir: | ||
| widget: "path_selector" | ||
| label: "Root Directory" | ||
| data-target-file-type: dirs # Valid values are: files, dirs, or both |
There was a problem hiding this comment.
This should actually be show_files: false.
There was a problem hiding this comment.
@ZQyou this data-target-file-type doesn't do anything here. You need show_files: false. Just FYI in case that's critical for this.
|
You may want to add |
|
Thanks. I just found out there is no default for empty field. I have fixed it. |
|
Added a safeguard to check non-existent or unreadable directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
path_selectorto allow users to select the root directory for their notebooks.