Skip to content

Conversation

@guyromellemagayano
Copy link
Contributor

@guyromellemagayano guyromellemagayano commented Nov 14, 2025

This pull request improves code quality in directives.js by suppressing console warnings and improving code readability.

Key changes:

  • Suppress console warnings by commenting out debug statements
  • Add underscore prefix to unused parameter prevVnode to suppress ESLint warnings
  • Improve code readability by using arrow functions with explicit parentheses
  • Format long lines for better readability
  • Remove trailing comma for consistency

This cleanup removes development debug output and improves code maintainability without changing functionality.

@guyromellemagayano guyromellemagayano force-pushed the refactor/directives-cleanup branch 6 times, most recently from 5042c51 to 6107eaf Compare November 15, 2025 06:10
…eadability

Clean up directives.js by suppressing console warnings and improving code
readability with better parameter naming and arrow functions.

Changes:
- Add underscore prefix to unused _prevVnode parameter to suppress warnings
- Comment out console.warn and console.log statements
- Refactor map and forEach callbacks to use arrow functions
- Improve code formatting and readability

This reduces console noise during development and improves code maintainability.
@guyromellemagayano guyromellemagayano force-pushed the refactor/directives-cleanup branch from 6107eaf to 581dab8 Compare November 15, 2025 07:15
@guyromellemagayano guyromellemagayano changed the title refactor(directives): Clean up code and suppress console warnings Refactor directives to clean up code and suppress console warnings Nov 16, 2025
@guyromellemagayano guyromellemagayano changed the title Refactor directives to clean up code and suppress console warnings Refactor directives.js to clean up code and suppress console warnings Nov 16, 2025
@guyromellemagayano guyromellemagayano deleted the refactor/directives-cleanup branch November 16, 2025 20:27
@guyromellemagayano guyromellemagayano restored the refactor/directives-cleanup branch November 16, 2025 20:29
Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks.

@guyromellemagayano guyromellemagayano changed the title Refactor directives.js to clean up code and suppress console warnings refactor(directives.js): Suppress console warnings and improve code readability Nov 18, 2025
Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See change request comments thanks

@jofftiquez jofftiquez closed this Nov 25, 2025
@guyromellemagayano guyromellemagayano deleted the refactor/directives-cleanup branch November 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants