Create TeamMemberCard component and refactor TeamPage
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyromellemagayano
force-pushed
the
feat/team-member-card
branch
2 times, most recently
from
7486200 to
beb6ddf
Compare
guyromellemagayano
changed the title
TeamMemberCard component and refactor TeamPageTeamMemberCard component and refactor TeamPage
Member
|
Kindly provide a screenshot of the component |
Contributor
Author
|
Here is a screenshot of the
|
This pull request extracts team member display logic into a reusable `TeamMemberCard` component to improve code maintainability and reduce duplication. Key changes: * Create `TeamMemberCard` component in `src/components/TeamMemberCard.vue` * Refactor `TeamPage` to use `TeamMemberCard` for both active and inactive members * Remove duplicate team member display code from `TeamPage` * Remove unused `smoothScroll` and `onGoToPanel` code * Add `:key` attributes to template loops for better Vue performance This reduces code duplication and makes team member display logic reusable across the application.
guyromellemagayano
force-pushed
the
feat/team-member-card
branch
from
beb6ddf to
fdbd95b
Compare
Member
|
Hi @guyromellemagayano I meant the actual screenshot of the working UI not the code. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract team member display logic into a reusable
TeamMemberCardcomponent to improve code maintainability and reduce duplication.Changes:
TeamMemberCardcomponent insrc/components/TeamMemberCard.vueTeamPageto useTeamMemberCardfor both active and inactive membersTeamPagesmoothScrollandonGoToPanelcodeThis reduces code duplication and makes team member display logic reusable across the application.