Skip to content

Allows start, end, justify-all and match-parent as text-align values. #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allows start, end, justify-all and match-parent as text-align values. #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion owasp-java-html-sanitizer/src/main/java/org/owasp/html/CssSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ Property forKey(String propertyName) {
Set<String> tableLayoutLiterals0 = j8().setOf(
"auto", "fixed", "inherit");
Set<String> textAlignLiterals0 = j8().setOf(
"center", "inherit", "justify");
"center", "end", "inherit", "justify", "justify-all", "match-parent", "start");
Set<String> textDecorationLiterals0 = j8().setOf(
"blink", "line-through", "overline", "underline");
Set<String> textTransformLiterals0 = j8().setOf(
Expand Down
17 changes: 17 additions & 0 deletions owasp-java-html-sanitizer/src/test/java/org/owasp/html/HtmlPolicyBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,6 +1294,23 @@ public final void testHtmlPolicyBuilderDefinitionWithNoAttributesDefinedGlobally
new HtmlPolicyBuilder().allowElements().allowAttributes().globally().toFactory();
}

@Test
public final void testCSSTextAlign() {
HtmlPolicyBuilder builder = new HtmlPolicyBuilder();
PolicyFactory factory = builder.allowElements("span")
.allowAttributes("style").onElements("span").allowStyling()
.toFactory();

String toSanitizeTextAlignStart = "<span style=\"text-align:start\">start</span>";
assertEquals(toSanitizeTextAlignStart, factory.sanitize(toSanitizeTextAlignStart));

String toSanitizeTextAlignEnd = "<span style=\"text-align:end\">end</span>";
assertEquals(toSanitizeTextAlignEnd, factory.sanitize(toSanitizeTextAlignEnd));

String toSanitizeTextAlignFoo = "<span style=\"text-align:foo\">foo</span>";
assertEquals("foo", factory.sanitize(toSanitizeTextAlignFoo));
}

@Test
public final void testCSSFontSize() {
HtmlPolicyBuilder builder = new HtmlPolicyBuilder();
Expand Down