Skip to content

Preserve order of rel attributes (#336) #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve order of rel attributes (#336) #352

wants to merge 1 commit into from
+30 −5

Conversation

strangelookingnerd
Copy link

@strangelookingnerd strangelookingnerd commented Jan 3, 2025 •
edited
Loading

Fixes regression introduced in 20240325.1 - see #336 for details.

  • Use LinkedHashSet to preserve insertion order where applicable - please note that there may be more regressions like this that have not yet been uncovered
  • Added test that demonstrates the fix works as intended. Without the fix, the test would fail on JDK > 8

@strangelookingnerd
Copy link
Author

Ping @mikesamuel can this please be merged and released?

@strangelookingnerd
Copy link
Author

@jmanico @mikesamuel Kindly requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@basil basil basil approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strangelookingnerd @basil