chore: Separate package version and Git resource functions from create release #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofflamrock
commented
Nov 1, 2024
| // finds the latest available version satisfying the channel version rules. Result is the list of step+package+versions | ||
| // to use as a baseline. The package version override process takes this as an input and layers on top of it | ||
| func BuildPackageVersionBaseline(octopus *octopusApiClient.Client, packages []releases.ReleaseTemplatePackage, | ||
| setAdditionalFeedQueryParameters func(releases.ReleaseTemplatePackage, feeds.SearchPackageVersionsQuery) (feeds.SearchPackageVersionsQuery, error)) ([]*StepPackageVersion, error) { |
Contributor
Author
There was a problem hiding this comment.
This function is moved over from the create releases one but has a couple of small change in it to make it generic and usable when creating Git runbooks and creating releases.
- It now takes in the package list directly instead of a
DeploymentProcessTemplate - When creating a release we need to check the channel rules for the associated package and add any additional search parameters to ensure that the version selected satisfies the rules. This parameter allows us to do that.
This was referenced Nov 14, 2024
geofflamrock
changed the title
stevencl840
approved these changes
Nov 19, 2024
geofflamrock
commented
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series that adds support to the CLI for interacting with runbooks stored in Git for version controlled projects
Background
Git runbooks operate differently to runbooks stored in the Octopus database in that there are no draft/published snapshots, these are replaced with running a runbook using a Git reference such as
main. This means that in order to run a runbook that uses packages or Git resources these need to be supplied as part of the run creation.Changes
This PR moves some of the common functions for resolving package versions and Git resources from the
releases/createpackage into their own packages.Reducing risk
There are lots of tests for creating releases which have had only mechanical changes, these should all pass and give us confidence that this change is good. We could look to separate some of the tests for package version resolution in this PR, however I've opted to tackle that separately to give us confidence in this initial change.