Skip to content

[IMP] Add getter for floats and avoid NullPointerExceptions in OValues #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pathob wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Add getter for floats and avoid NullPointerExceptions in OValues #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions app/src/main/java/com/odoo/core/orm/OValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,26 +58,39 @@ public Object get(String key) {
return _values.get(key);
}

public long getLong(String key) {
if (_values.get(key).toString().equals("false")) {
return -1;
public Long getLong(String key) {
if (!contains(key) || get(key).toString().equals("false")) {
return -1L;
}
return Long.parseLong(_values.get(key).toString());
return Long.parseLong(get(key).toString());
}

public Integer getInt(String key) {
if (_values.get(key).toString().equals("false")) {
if (!contains(key) || get(key).toString().equals("false")) {
return -1;
}
return Integer.parseInt(_values.get(key).toString());
return Integer.parseInt(get(key).toString());
}

public Float getFloat(String key) {
if (!contains(key) || get(key).toString().equals("false")) {
return -1f;
}
return Float.parseFloat(get(key).toString());
}

public String getString(String key) {
return _values.get(key).toString();
if (!contains(key)) {
return "";
}
return get(key).toString();
}

public Boolean getBoolean(String key) {
return Boolean.parseBoolean(_values.get(key).toString());
if (!contains(key)) {
return false;
}
return Boolean.parseBoolean(get(key).toString());
}

public boolean contains(String key) {
Expand Down