-
Notifications
You must be signed in to change notification settings - Fork 0
V2 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
OffsetMonkey538
wants to merge
49
commits into
master
Choose a base branch
from
v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V2 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh my fucking god how did i not know this was possible this is so useful for like idk some other projects as well oh my fucking goddddddd
have not tested if this actually works cause nothing invokes the disable method, but yeah sure
…om HttpHandler to there
(why tf was I using -all???)
…nice (optional) directory index page
…erve index.html files
…ig command that allows reloading
I guess the router record itself might not be the best place, but it shouldn't have any bad effects as it's a static method? idk, I guess separating it into two methods (one for and in HttpRule and the other for/in Httphandler) could also make sense, but yeah idk this'll be fineeeeee I promiseeee
todo: move most of the example routers from ExampleMain to files
Not sure if I need to do anything bout this or not, but all the paths will be absolute because that's what the handlers store and that's what jankson saves...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.