-
Notifications
You must be signed in to change notification settings - Fork 57
Terra Classic support #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: touch
Are you sure you want to change the base?
Conversation
WalkthroughA new entry for the Terra Classic blockchain was added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
core/src/trezor/lvglui/res/chain-terra.pngis excluded by!**/*.png
📒 Files selected for processing (1)
core/src/apps/cosmos/networks.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.12.2)
core/src/apps/cosmos/networks.py
409-409: SyntaxError: Unexpected indentation
🔇 Additional comments (1)
core/src/apps/cosmos/networks.py (1)
415-415: Confirm Terra Classic bech32 prefix
The HRP is set to"LUNC"(uppercase), but bech32 prefixes are case-sensitive and typically lowercase. Terra Classic addresses use the prefix"terra". Please verify against official Terra Classic docs and update if needed.– File: core/src/apps/cosmos/networks.py
– Line: 415Proposed diff (if HRP should be
"terra"):- "LUNC", + "terra",
Summary by CodeRabbit