Skip to content

Conversation

ypfaff
Copy link
Contributor

@ypfaff ypfaff commented Aug 18, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

What's changed

Updated the Spring generator documentation to correctly show the actual defaults for discriminator-related properties:

  • useOneOfInterfaces: true (was documented as false)
  • legacyDiscriminatorBehavior: false (was documented as true)

Why

The documentation didn't match the actual behavior of the Spring generator for these discriminator properties.

@ypfaff ypfaff changed the title docs(spring): correct default for 'useOneOfInterfaces' to true docs(spring): fix discriminator property defaults and improve configurability Aug 22, 2025
@ypfaff ypfaff changed the title docs(spring): fix discriminator property defaults and improve configurability docs(spring): fix discriminator property defaults Aug 22, 2025
@ypfaff ypfaff force-pushed the docs/spring-useOneOfInterfaces-default-true branch from 6b5f17d to 724df33 Compare August 22, 2025 19:05
@ypfaff ypfaff requested a review from wing328 August 22, 2025 19:16
@ypfaff ypfaff force-pushed the docs/spring-useOneOfInterfaces-default-true branch from 724df33 to a51cb72 Compare August 23, 2025 09:07
@wing328 wing328 merged commit e1447bc into OpenAPITools:master Aug 27, 2025
14 checks passed
@wing328
Copy link
Member

wing328 commented Aug 27, 2025

thanks for the pr, which has been merged

@wing328 wing328 added this to the 7.16.0 milestone Aug 27, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants