Skip to content

Conversation

@whirm
Copy link
Contributor

@whirm whirm commented Nov 27, 2025

I've updated the samples and related configs to enable useAsyncFileStream where necessary.

I've also sneaked in a fix for incorrect code generation, which I'd like someone to have a closer look:

https://github.com/OpenAPITools/openapi-generator/compare/master...whirm:feat/rust-request-multipart-file-uploads?expand=1#diff-560675cd0a01bd295018250fac1197e39c9cb662a6ccc8e15785d94f2b2ca769L423-R435

Now only primitive type parts get stringified with .to_string(), the rest are serialized to json. AFAICT that's the way to go.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

closes: #17822

@frol, @farcaller, @richardwhiuk, @paladinzh, @jacob-pro, @linxGnu Ready to review!

@wing328
Copy link
Member

wing328 commented Nov 28, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@whirm whirm force-pushed the feat/rust-request-multipart-file-uploads branch from a8236cc to 7c630ad Compare November 28, 2025 08:23
@whirm
Copy link
Contributor Author

whirm commented Nov 28, 2025

Oops, I forgot I was on a different laptop! Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] file uploads not supported by the Rust generator

2 participants