Skip to content

Optimize handleResize and fetchData methods in RepoSummary page #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −39
Open

Optimize handleResize and fetchData methods in RepoSummary page #1063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 31 additions & 39 deletions frontend/src/components/shared/RepoSummary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,53 +131,47 @@
const endpoint = ref({})
const datasetInfo = ref(null)

const handleResize = () => {
const windowWidth = window.innerWidth;
if (windowWidth <= 640) {
dialogWidth.value = '100%';
} else if (windowWidth <= 768) {
dialogWidth.value = '500';
} else if (windowWidth <= 1024) {
dialogWidth.value = '700';
} else {
dialogWidth.value = '800';
}
const handleResize = () => {
const widthMap = { 640: '100%', 768: '500', 1024: '700' };
dialogWidth.value = widthMap[Object.keys(widthMap).find(key => window.innerWidth <= key)] || '800';
};

const fetchData = async () => {
const endpoints = {
readme: `/${props.repoType}s/${props.namespacePath}/blob/README.md`,
catalog: `datasets/${props.namespacePath}/dataviewer/catalog`,
relations: `/${props.repoType}s/${props.namespacePath}/relations`,
};

const fetchData = async () => {
const url = `/${props.repoType}s/${props.namespacePath}/blob/README.md`
const fetchEndpointData = async (url) => {
const { error, data } = await useFetchApi(url).json();
return { error, data };
};

const { data } = await useFetchApi(url).json()
const [readmeResponse, catalogResponse, relationsResponse] = await Promise.all([
fetchEndpointData(endpoints.readme),
props.repoType === 'dataset' ? fetchEndpointData(endpoints.catalog) : null,
fetchEndpointData(endpoints.relations),
]);

if (data.value) {
rawReadmeContent.value = data.value.data.content
resolveReadmeContent()
}
loading.value = false
if (readmeResponse.data?.value) {
rawReadmeContent.value = readmeResponse.data.value.data.content;
resolveReadmeContent();
}

const fetchCatalog = async () => {
if (props.repoType !== 'dataset') return

const { error, data } = await useFetchApi(
`datasets/${props.namespacePath}/dataviewer/catalog`
).json()

if (data.value) {
datasetInfo.value = data.value.data.dataset_info
} else {
ElMessage.warning(error.value.msg || t('all.fetchError'))
}
if (catalogResponse?.data?.value) {
datasetInfo.value = catalogResponse.data.value.data.dataset_info;
} else if (catalogResponse?.error?.value) {
ElMessage.warning(catalogResponse.error.value.msg || t('all.fetchError'));
}

const fetchRepoRelations = async () => {
const url = `/${props.repoType}s/${props.namespacePath}/relations`
const { data } = await useFetchApi(url).json()
if (data.value) {
relations.value = data.value.data
}
if (relationsResponse.data?.value) {
relations.value = relationsResponse.data.value.data;
}

loading.value = false;
};

const appEndpoint = computed(() => {
if (!endpoint.value) return ''

Expand All @@ -203,8 +197,6 @@

onMounted(() => {
fetchData()
fetchCatalog()
fetchRepoRelations()
if (props.repoType == 'model') {
fetchEndpoint()
}
Expand Down