Skip to content

Ubuntu 24.04 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: ODM
Choose a base branch
from
Open

Ubuntu 24.04 #15

wants to merge 17 commits into from

Conversation

NathanMOlson
Copy link

This PR brings in the latest updates from nmoehrle/mvs-texturing.

@NathanMOlson
Copy link
Author

@smathermather the change log looks different here than I expect. I think maybe you created the ODM branch off of 101 (or something old, not 300?

In the ODM forum, you said "It’s not apples-to-apples, given upstreaming to e.g. MVS-Texturing without some of the texturing mods...Unsurprisingly, missing MVS-Texturing features specific to orthophotos". However, I believe this contains all the ODM-specific changes from 300. Can you send me the command line to run to check the orthophoto functionality?

@smathermather smathermather deleted the branch OpenDroneMap:ODM August 12, 2025 19:53
@smathermather smathermather reopened this Aug 12, 2025
@smathermather
Copy link

smathermather commented Aug 12, 2025

The heat must be getting to me. This is now branched off 300. Let me double check the other ODM branches and make sure my branching is correct. Will confirm on OpenDroneMap/ODM#1904 once complete.

As far as changes to support orthos, you'll see API changes allowing for the choice of the most nadir texture instead of the most orthogonal texture, and we can see that in the roof looking brighter on all facets in the Toledo test dataset:

It's a minor thing, but in complicated datasets, it makes a big difference in ensuring the most orthogonal view for the orthophoto, which improves corners and edges substantially.

@NathanMOlson
Copy link
Author

@smathermather Thanks, the changelog looks as expected now.

As you can see, the changes from 300 are pretty minimal, and none look like they would effect the orthophoto... maybe the issue is happening outside mvs-texturing. I'll dig in further.

@smathermather
Copy link

smathermather commented Aug 12, 2025

As you can see, the changes from 300 are pretty minimal, and none look like they would effect the orthophoto... maybe the issue is happening outside mvs-texturing. I'll dig in further.

It's probably no longer an issue? You had the version I was testing pointed to upstream which lacks an exposed --nadir-weight.

Relevant pull request here:
#6

@NathanMOlson
Copy link
Author

It's probably no longer an issue? You had the version I was testing pointed to upstream which lacks an exposed --nadir-weight.

Hmm, I haven't published any versions that pointed to an upstream mvs-texturing. So I think there's still an issue to resolve here.

@smathermather
Copy link

I'm sure it was user error on my part. Currently testing with https://github.com/NathanMOlson/ODM and getting fine results (differences are due to mvs-texturing being non-deterministic when multi-threaded):
texturing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants