-
-
Notifications
You must be signed in to change notification settings - Fork 67
Add ssc377_lite_tp-link-tapo-c120-v1 profile #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ssc377_lite_tp-link-tapo-c120-v1 profile #57
Conversation
debe03d
to
9bbe14e
Compare
Thanks for the PR, @asyncbridge did you successfully get the Tapo C120 with SC340AI to work with OpenIPC? I noticed a few GitHub issues relating to it as well |
No, I haven't been successful either, so I reached out to OpenIPC tech support for assistance. |
44889b6
to
c6db1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need clarification on what has changed relative to the base file.
Perhaps it would be correct to make changes to the Firmware repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only add sc430ai to set_sensor() (no other changes) in this file.
...
set_sensor() {
case $SENSOR in
gc4653|imx335|imx415|os04a10|sc4336p|sc401ai|sc430ai|sc501ai|sc830ai|sc850sl)
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of using this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this file from the previous builder’s PR for consistency. There isn’t a particular new purpose on my side, so please let me know if it should be removed.
There may be an error calling the driver package.
Add configuration for the TP-Link Tapo C120 v1.