Fix transfer pool thread safety #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unsafe access during transfer resubmission by refactoring TransferPool using std::vector. Wait for all transfers during cancellation.
|
Tested. Cleaner and faster shutdown. Seems to work well. |
|
Tested on Windows. Works great. |
This was referenced Jun 8, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unsafe access during transfer resubmission by refactoring TransferPool using std::vector. It seems there is no need to maintain a queue for the case when a transfer may temporarily fail and recover. If one transfer fails, it is likely all will fail permanently.
Each transfer is independent during runtime and no lock is needed.
Wait for all transfers during cancellation, when the only lock in the TransferPool protects the counter of stopped transfers. Though coarse-grained, this lock will not have effect on runtime performance.
This has been tested on Linux, Windows, and Mac. No crashes are observed, and shutdown time is reduced.
This PR proposes to subsume #212.