-
-
Notifications
You must be signed in to change notification settings - Fork 449
Remove deprecated Mage_Captcha module and references #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: addison74 <[email protected]>
Co-authored-by: addison74 <[email protected]>
Test Results810 tests - 1 799 ✅ - 1 7s ⏱️ ±0s Results for commit 93e7f79. ± Comparison against base commit 24cd60d. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Remove ignoreErrors for Mage_Captcha
This module needs to be backend up in a repository, like we did with other modules. If anyone is ever interested in upgrading it, it is a starting point. I don't have the rights to create repositories in OpenMage and there is a repository created already. |
@addison74 i'm trying to extract the Captcha Module into that other Repo (i think i have access to it?) The problems are going to be the admin login templates, because they got no nice block where I could add the includes. (for Security reason?) |
@copilot The CI workflow is failing due to PHPUnit errors. Please update the code so that all workflows pass. |
the failed testFormatTimezoneDate is kinda funky, It seems to have been run exactly when the Datetime flipped |
Co-authored-by: addison74 <[email protected]>
Fixed the PHPUnit errors by removing all Mage_Captcha references from the PHPStorm metadata files in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
👍 |
We have https://github.com/OpenMage/module-mage-captcha, but its private atm and i cant change it. @colinmollenhour? |
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.