Skip to content

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 1, 2025

(it will fail for v8)

edit: composer-plugin added license-files for TinyMCE v7.x, but not for v8.x (or later). Fixed in v3.1.

@github-actions github-actions bot added the composer Relates to composer.json label Oct 2, 2025
@sreichel sreichel changed the title Add test for existing TinyMCE license files Fix missing TinyMCE license files + tests Oct 2, 2025
@sreichel sreichel marked this pull request as ready for review October 2, 2025 01:32
@sreichel sreichel requested a review from Copilot October 2, 2025 01:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Ensures TinyMCE license files are present and verified by unit tests; bumps composer plugin to pick up related install behaviors.

  • Add PHPUnit tests to assert presence of TinyMCE license files in project root and vendor directory.
  • Update dependency constraint openmage/composer-plugin from ^3.0 to ^3.1.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/unit/Base/TinyMCELicenseTest.php Adds tests that check for TinyMCE license files; uses Composer InstalledVersions to gate tests.
composer.json Bumps openmage/composer-plugin to ^3.1.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

sonarqubecloud bot commented Oct 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json phpunit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants