Skip to content

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 3, 2024

https://dev.azure.com/martinkroeker/martinkroeker/_build/results?buildId=1472&view=logs&j=0f344e18-ca8b-5780-26f4-6ba48d8d5454&t=33e34d53-76bc-5543-18c4-9ff7691b1623:

In file included from c_sblas1.c:10:
cblas_test.h:18: warning: "FAILED" redefined
   18 | #define  FAILED         0
      | 
In file included from C:/mingw64/x86_64-w64-mingw32/include/winbase.h:2811,
                 from C:/mingw64/x86_64-w64-mingw32/include/windows.h:70,
                 from ../common.h:119,
                 from c_sblas1.c:9:
C:/mingw64/x86_64-w64-mingw32/include/winerror.h:2235: note: this is the location of the previous definition
 2235 | #define FAILED(hr) ((HRESULT)(hr) < 0)

The more invasive alternative is to use a unique prefix.

@martin-frbg
Copy link
Collaborator

I think this is only ever used in the local ctest/c_xerbla.c file, so changing this to TEST_FAILED or whatever should also be reasonable. (The same problem probably exists in the Reference-LAPACK source from which these tests were originally taken)

@martin-frbg martin-frbg added this to the 0.3.29 milestone Dec 4, 2024
@martin-frbg martin-frbg merged commit 9c5d201 into OpenMathLib:develop Dec 4, 2024
81 of 83 checks passed
@dg0yt dg0yt deleted the macro-failed branch December 5, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants