Skip to content

Conversation

@vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Dec 11, 2025

Guard .align directive to avoid internal compiler error on
AArch64 Windows with clang.

See: llvm/llvm-project#149547
See: #5076, which applied this same fix to the other files

Co-Authored-By: Claude Opus 4.5 [email protected]

Guard .align directive to avoid internal compiler error on
AArch64 Windows with clang.

See: llvm/llvm-project#149547
See: OpenMathLib#5076

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@vtjnash vtjnash force-pushed the jn/zdot_thunderx2t99-ICE branch from 9a245e7 to d38be78 Compare December 12, 2025 16:48
@martin-frbg
Copy link
Collaborator

I'm pretty sure that alignment wasn't the only issue preventing successful compilation of this file at the time, else I wouldn't have treated it differently, just a day after fixing the other thunderx kernels in the same PR. Did you check that it actually works now on real WoA hardware ?

@martin-frbg
Copy link
Collaborator

This is not wrong, but it serves no purpose as long as there are other issues precluding use of this file on WoA

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 15, 2025

I do have real WoA hardware, so I'm happy to do any test for you (it isn't a THUNDERX2T99, but I can ask my colleague who has that hardware vendor if he can test also, if you need that). I don't know why you missed it, but don't see how that is relevant to the present existence of the bug here. The point of this is to be able to even test anything, as otherwise the flang compiler crashes and I don't get to even attempt to test the results. With this fix, (and with my other two bugfixes to the makefile) then everything compiles successfully. The fix I assumed was obviously correct on its own, since it is already required and implemented in many of the other files, so it shouldn't need any more justification.

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 25, 2025

I can force push my rebase of this to fix the remaining bugs here, but you need to reopen first, or github will prevent it from being reopened and force me to make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants