-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add visibility=default to exported functions, visibility=hidden to most assembler #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| .SUFFIXES: .c .o | ||
| .c.o: | ||
| $(CC) $(CFLAGS) -I../include -c -o $@ $< | ||
| $(CC) $(filter-out -fvisibility=hidden, $(CFLAGS)) -I../include -c -o $@ $< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than add OPENBLAS_EXPORT to all the functions here and in ../utils, I removed the flag from the Makefile. I should do the same for the CMake. How does one tweak the flags per-directory in CMake?
|
The clang builds are complaining about the assembler directive But the passing gcc builds are happy enough with it. I wonder if there is another way to tell clang to hide the assembler function without resorting to |
|
I got the documentation for |
|
The Windows_cl job is failing since on windows I need the full The other failures are due to timeouts or network issues, and I don't think they are connected to this PR. I am still thinking about the best way to add |
|
Ahh, the shipped |
Towards #5560
OPENBLAS_EXPORTmacro that maps to__attribute__ ((visibility ("default")))interfacesand some inkernels/genericPROLOGUEassembler macro to hide functions by default, and use aPROLOGUE_EXPORTmacro where functions should be exportedWhere would be the best place to add a non-MSVC default
-fvisibility=hidden? Somewhere inMakefile.systemI guess, but how/where?Note most of this was done as part of MacPython/openblas-libs#241, and I tested it there on the most popular builds.