Remove arbeitzeisatz when cancelling arbeitsangebot #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlwinEgger
requested changes
Oct 15, 2025
|
|
||
| private def prependAbgesagt(existing: Option[String]): Option[String] = | ||
| existing match { | ||
| case Some(txt) if txt.trim.startsWith("<span class=\"status-icon cancelled\" title=\"Cancelled\">❌</span>") => Some(txt) // already prefixed |
Member
There was a problem hiding this comment.
Adding HTML to the Field is not very nice.
In addition we add something to a field the person has added their comments.
Shouldn't we display the icon on the UI based on the Arbeitseinsatz.Status? Updating the Status is absolutely fine.
| case UserCommandFailed => | ||
| complete(StatusCodes.BadRequest, s"Could not cancel the Arbeitsangebot, please check the input data.") | ||
| case _ => | ||
| complete(StatusCodes.OK, "Arbeitsangebot cancelled and related einsätze removed.") |
Member
There was a problem hiding this comment.
Not true, the Arbeitseinsatz was not removed but the Status is set to Abgesagt
AlwinEgger
requested changes
Dec 9, 2025
| val einsatzModify = copyTo[Arbeitseinsatz, ArbeitseinsatzModify]( | ||
| einsatz, | ||
| "status" -> Abgesagt, | ||
| "bemerkungen" -> updatedBemerkungen |
Member
There was a problem hiding this comment.
You are overwriting the bemerkungen field from the same object. Didn't you want to append the bemerkung of the arbeitsangebot or something?
Member
Author
There was a problem hiding this comment.
You are right, this is not required anymore. Now this is handled on frontend.
|
AlwinEgger
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.