[WIP] Enable trainrun asymmetry

[louisgreiner]

In pair programming with @Yohh

Description

PR linked with issue on OSRD OpenRailAssociation repository : OpenRailAssociation/osrd#10576

PR work in progress, for exploration and review purposes

How to review properly

B) TrainrunSection arrival/departure time at nodes

Test all the different combinaisons of +/- 1 for the 5 different time values, and also for all locks combinaisons:

• leftDeparture / rightArrival / rightDeparture / leftArrival / travelTime
• leftLock / travelTimeLock / rightLock

left = source and right = target

Warning

Since the returnTravelTime is a new feature in the PR, it might break the B) feature at some points

The symmetry is defined at the trainrun section level.

When symmetry is off, only show the travelTime:

When symmetry is off, only show the travelTime:

C) Enable one-way trip

Warning

The return times (targetDeparture and sourceArrival) are only css-hidden, accordingly to the way NGE currently hides elements

Warning

Bug: when a trainrun is non-stopping at a node, the times for the trainrun dialog window are all hidden (because the target is not direct left/right)

Defined on a trainrun level:

The view of a section, left->right:

The view of a section, right->left:

D) Enable different travel times for round trips

Question: should we rename travelTime and returnTravelTime into forwardTravelTime and backwardTravelTime? I'm not a huge fan of backward, since we don't really go backward, rather forward also, but in another direction.

OR : should we rename it upTravelTime and downTravelTime to stick to the left/right paradigm ; if we stick to the source/target paradigm, we should stay with travelTime and returnTravelTime

Question: should the sourceArrival and targetDeparture (the return trip) be calculated with returnTravelTime or with travelTime

The current solution for displaying the returnTravelTime are:

• if the trainrun section is symmetric:
  

• if the trainrun section is asymmetric, and travelTime !== returnTravelTime:
  

• if the trainrun section is asymmetric, and travelTime === returnTravelTime:
  

This feature is not finished at all.

Remaining to do

Bugs:

• for C) fix display times for non-stopping nodes (see above)
• Many things for the D) feature
• for B), display the returnTravelTime for right->left nodes, instead of travelTime
• for D) display travelTime instead of returnTravelTime when left<->right nodes are inverted

Spread the features for the rest of the application:

• Pearls view (Perlenkette) doesn't take in account the above features, need to spread the changes to it:
  • B) TrainrunSection arrival/departure time at nodes
  • C) Enable one-way trip
  • D) Enable different travel times for round trips
• Space-time diagram (Streckengrafik) doesn't take in account the above features, need to spread the changes to it:
  • B) TrainrunSection arrival/departure time at nodes
  • C) Enable one-way trip
  • D) Enable different travel times for round trips
• For D), take in account non-stops for extractTravelTime()

List of features / fixes that would be nice to do if we have the time:

• Re-calculate symmetric values when symmetric toggle is hit (propagation)
• Documentation on code additions
• for B), when asymmetry is on
  • current behaviour: +/- 1 leftDepature and +/- 1 leftArrival change the same travelTime
  • target behaviour: +/- 1 leftDepature and +/- 1 leftArrival change a different travelTime
• fix behaviour when travelTime is reduced to 0
  • current behaviour: rounds to 0.1, then propagating to the other time values with decimal
  • target behaviour: goes to 60, not modifying the other time values
• For B) and C), use a toggle from SBB design system instead of checkbox
• Set custom input for node symmetry (something else than 60')

Issues

Checklist

• This PR contains a description of the changes I'm making
• I've read the Contribution Guidelines
• I've added tests for changes or features I've introduced
• I documented any high-level concepts I'm introducing in documentation/
• CI is currently green and this is ready for review

[louisgreiner]

Closing since both real PRs are well enough started:

• Current PR (one-ways): Enable one way trainruns #477
• Current PR (full asymmetry): [wip] full asymmetry #501