-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for AliExpress variant of EPS32-S3 Zero #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FynnleyNeko
wants to merge
3
commits into
OpenShock:develop
Choose a base branch
from
FynnleyNeko:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "build": { | ||
| "arduino":{ | ||
| "partitions": "default.csv", | ||
| "memory_type": "qio_qspi" | ||
| }, | ||
| "core": "esp32", | ||
| "extra_flags": [ | ||
| "-DARDUINO_ESP32S3_DEV", | ||
| "-DARDUINO_RUNNING_CORE=1", | ||
| "-DARDUINO_EVENT_RUNNING_CORE=1", | ||
| "-DARDUINO_USB_CDC_ON_BOOT=1", | ||
| "-DBOARD_HAS_PSRAM" | ||
| ], | ||
| "f_cpu": "240000000L", | ||
| "f_flash": "80000000L", | ||
| "flash_mode": "qio", | ||
| "psram_type": "qio", | ||
| "hwids": [ | ||
| [ | ||
| "0x303A", | ||
| "0x1001" | ||
| ] | ||
| ], | ||
| "mcu": "esp32s3", | ||
| "variant": "esp32s3" | ||
| }, | ||
| "connectivity": [ | ||
| "wifi", | ||
| "bluetooth" | ||
| ], | ||
| "debug": { | ||
| "default_tool": "esp-builtin", | ||
| "onboard_tools": [ | ||
| "esp-builtin" | ||
| ], | ||
| "openocd_target": "esp32s3.cfg" | ||
| }, | ||
| "frameworks": [ | ||
| "arduino", | ||
| "espidf" | ||
| ], | ||
| "platforms" : [ | ||
| "espressif32" | ||
| ], | ||
| "name": "Espressif ESP32-S3-FH4R2 (4 MB QD, 2MB PSRAM)", | ||
| "upload": { | ||
| "flash_size": "4MB", | ||
| "maximum_ram_size": 327680, | ||
| "maximum_size": 4194304, | ||
| "require_upload_port": true, | ||
| "speed": 921600 | ||
| }, | ||
| "url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html", | ||
| "vendor": "Espressif" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same chip as the Aliexpress clone of it, it differs from the devkitc-1 in having PSRAM, requiring USB-CDC, different flash size and having faster upload speeds, so that's all defined inside the definition.
But that being said that was something I didn't actually intend to include in the request, but it was something I wanted to have in my fork for building and testing.
It obviously compiles as a devkitc-1 just fine, so the change wasn't required, but declaring it as one is technically not the correct board definition.