Test: Automation for netsniff-ng packet capture #1241
+924
−442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change test cases names; Adjust logging;
MateuszGrabuszynski
changed the title
MateuszGrabuszynski
changed the title
…bug and FIXME comment
…instead of all traffic
MateuszGrabuszynski
requested review from
Sakoram,
DawidWesierski4 and
Falron98
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds automation support for netsniff-ng packet capture alongside existing tcpdump functionality, allowing test configuration to choose between capture tools via a tool parameter. The implementation includes a new NetsniffRecorder class modeled after TcpDumpRecorder and updates test files to support both capture methods.
- Introduces conditional packet capture execution for netsniff-ng across test execution engines
- Adds NetsniffRecorder class for netsniff-ng packet capture automation
- Updates comment consistency to reflect actual configuration behavior rather than just tcpdump
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validation/configs/test_config.yaml | Adds tool configuration option for capture method selection |
| tests/validation/create_pcap_file/netsniff.py | New NetsniffRecorder class implementation for netsniff-ng automation |
| tests/validation/mtl_engine/RxTxApp.py | Adds netsniff support and fixes dual test interface configuration |
| tests/validation/mtl_engine/ffmpeg_app.py | Integrates netsniff capture in ffmpeg tests and adds new dual test functions |
| tests/validation/mtl_engine/GstreamerApp.py | Adds netsniff capture support to GStreamer tests |
| tests/validation/mtl_engine/udp_app.py | Integrates netsniff capture in UDP application tests |
| Multiple test files | Updates comments to reflect packet capture configuration rather than tcpdump-specific |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MateuszGrabuszynski
force-pushed
the
netsniff-autom
branch
from
75f6394 to
01bad5b
Compare
MateuszGrabuszynski
force-pushed
the
netsniff-autom
branch
from
a77c7bd to
cb29b49
Compare
MateuszGrabuszynski
force-pushed
the
netsniff-autom
branch
from
cb29b49 to
48bec15
Compare
…rge conflict resolution
…are to be fully moved to a fixture
andremiszcz
force-pushed
the
netsniff-autom
branch
from
2981ce6 to
45b7a4b
Compare
andremiszcz
force-pushed
the
netsniff-autom
branch
2 times, most recently
from
a5ff5d2 to
ae475c7
Compare
andremiszcz
force-pushed
the
netsniff-autom
branch
from
ae475c7 to
3d8c045
Compare
staszczuk
requested changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcap_capture fixture prepared:
gather info from test_config about capture options like frame_number or capture time
create NetsniffRecorder class and yields the object
connect to the EBU server (info from test config)
send pcap to EBU list and gather compiance result
NetsniffRecorder class:
netsniff-ng wrapper for capturing packets
RxTxApp adaptation for packet capturing during traffic with netsniff obejct
Test cases adaptation (ST20 ST30 - video and audio, these which type_mode is mutlicast)