Skip to content

Conversation

mdqst
Copy link

@mdqst mdqst commented Sep 14, 2025

updated compare_subdicts and markdown_subtable to safely handle cases where old[file] or new[file] might be None.
using (old.get(file) or {}).get(metric) and (new.get(file) or {}).get(metric) prevents AttributeError and ensures the comparison works reliably.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

codecov bot commented Sep 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (fc94206) to head (0c75053).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          82       82           
  Lines        2272     2272           
=======================================
  Hits         2099     2099           
  Misses        173      173           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc94206...0c75053. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant