Skip to content

Kr/deprecations #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Kr/deprecations #546

wants to merge 4 commits into from

Conversation

rocktavious
Copy link
Collaborator

@rocktavious rocktavious commented May 14, 2025

Resolves #

Problem

None

Solution

During the latest round of client-gen it found a bunch of deprecations

I think we'll need to figure out the best way to communicate these to customers

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious requested a review from jasonopslevel May 14, 2025 21:43
@rocktavious rocktavious self-assigned this May 14, 2025
@rocktavious rocktavious changed the base branch from main to kr/add-invoke-action May 14, 2025 21:44
@jasonopslevel
Copy link
Contributor

We don't plan on removing the deprecated methods anytime soon, so we could alternative choose to not remove them from opslevel-go either. If there's an option in the codegen to ignore deprecations, we could do that too.

@rocktavious
Copy link
Collaborator Author

@jasonopslevel - one of these deprecations has already caused customer confusion - the ManagerEmail field So i think it might be worth doing some of these things. I just need to think through the right away to go about this.

Base automatically changed from kr/add-invoke-action to main May 15, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants