Skip to content

Conversation

AlexV525
Copy link

@AlexV525 AlexV525 commented Sep 1, 2025

  1. The interface of the storage has been extracted from the default implementation. Users can implement their own instead of using Get Storage or Shared Preferences.
  2. The default fields can be updated instead of final.

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, few questions and changes.

@AlexV525
Copy link
Author

AlexV525 commented Sep 1, 2025

I've made a couple of changes additionally:

  1. The storage interface was extracted with a more general interface that can be used to store any type of data.
  2. I've renamed VideoPlayerStorage to VideoPlayerMetadataStorage and made a type alias to deprecate VideoPlayerStorage, but I think we can safely remove it since the class was not exported directly before.

@AlexV525 AlexV525 requested a review from OutdatedGuy September 3, 2025 17:51
@AlexV525
Copy link
Author

@OutdatedGuy friendly ping

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will once check updated example app and then merge.

Thanks for the contribution!

@OutdatedGuy
Copy link
Owner

Screen.Recording.2025-10-04.at.12.39.48.PM.mov

@AlexV525 the example app doesn't seems to be working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants