Skip to content

Conversation

@P-H-Phuc
Copy link
Owner

@P-H-Phuc P-H-Phuc commented Nov 17, 2025

  • Add config display button and show warning on button remove order line
image image

ISSUE

@P-H-Phuc P-H-Phuc changed the title [18.0][IMP] Add config show button remove order line [18.0][IMP] pos_order_remove_line: Add config show button remove order line Nov 17, 2025
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add/update the translation: *.pot and fr.po
  • Incorrect behavior:
Screencast.from.20-11-2025.16.44.58.webm

/>
</div>
<div>
<field name="pos_line_remove_warning" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show it only when pos_line_remove_btn is ticked

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to click 2 times to remove item, it focus to paren element, I will check it

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show the remove button only when the order line is selected!

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a good idea. Always show the btn as it's.
Try to solve the issue. Spend more time, let me know if you cannot find the solution then.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast.from.2025-11-25.11-33-41.webm

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve! please help me to review this

@P-H-Phuc P-H-Phuc force-pushed the 18.0-imp-pos_order_remove_line branch 2 times, most recently from b977fc6 to 5bda1ce Compare November 24, 2025 04:49
@P-H-Phuc
Copy link
Owner Author

Resolved

/>
</div>
<div>
<field name="pos_line_remove_warning" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a good idea. Always show the btn as it's.
Try to solve the issue. Spend more time, let me know if you cannot find the solution then.

@P-H-Phuc P-H-Phuc force-pushed the 18.0-imp-pos_order_remove_line branch from 5bda1ce to 7722cad Compare November 25, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants