Skip to content

Prepare for next development iteration 21.4.0-SNAPSHOT #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 21.x
Choose a base branch
from
Open

Prepare for next development iteration 21.4.0-SNAPSHOT #2322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a61143f
Bump spring to 3.4.0
Tobianas Oct 2, 2025
07816a6
Set spring.http.client.factory to jdk
ihrasko Mar 21, 2025
e11c4ea
Bump spotbugs-maven-plugin to 4.8.6.7
Tobianas Oct 2, 2025
fd23139
Bump checkstyle to 11.0.1
Tobianas Oct 2, 2025
c120e5a
Bump docs and scripts to 21.3.0
Tobianas Aug 27, 2025
e56b895
[maven-release-plugin] prepare release 21.3.0
Tobianas Aug 27, 2025
8675956
[maven-release-plugin] prepare for next development iteration
Tobianas Aug 27, 2025
58a8952
Bump docs and scripts to 21.4.0-SNAPSHOT
Tobianas Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lighty-rcgnmi-app/tests-lighty-rcgnmi-app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ls -1 yangs
#Run simulator for testing purpose
printLine
echo -e "-- Starting gNMI simulator device --\n"
java -jar ${GITHUB_WORKSPACE}/lighty-modules/lighty-gnmi/lighty-gnmi-device-simulator/target/lighty-gnmi-device-simulator-21.3.0-SNAPSHOT.jar -c ./simulator/example_config.json > /dev/null 2>&1 &
java -jar ${GITHUB_WORKSPACE}/lighty-modules/lighty-gnmi/lighty-gnmi-device-simulator/target/lighty-gnmi-device-simulator-21.4.0-SNAPSHOT.jar -c ./simulator/example_config.json > /dev/null 2>&1 &

#Add yangs into controller through REST rpc
./add_yangs_via_rpc.sh
Expand Down
2 changes: 1 addition & 1 deletion lighty-applications/lighty-app-modules-config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../../lighty-core/lighty-parent/pom.xml</relativePath>
</parent>

Expand Down
9 changes: 3 additions & 6 deletions lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-docker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@
~ and is available at https://www.eclipse.org/legal/epl-v10.html
-->

<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's good practice to have each attribute of an XML tag on a new line, especially when there are multiple attributes. This makes the POM file easier to read and maintain.

Suggested change
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>

<groupId>io.lighty.applications.rcgnmi</groupId>
<artifactId>lighty-rcgnmi-app-docker</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>

<properties>
<image.name>lighty-rcgnmi</image.name>
Expand Down Expand Up @@ -81,8 +79,7 @@
<phase>prepare-package</phase>
<configuration>
<target>
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's recommended to keep attributes of XML tags on separate lines, especially for long lines like this one. This makes the code easier to read and understand.

                                <unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}"
                                       dest="${basedir}/target/docker-stage" />

</target>
</configuration>
<goals>
Expand Down
4 changes: 2 additions & 2 deletions lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../../../lighty-core/lighty-parent/pom.xml</relativePath>
</parent>

<groupId>io.lighty.applications.rcgnmi</groupId>
<artifactId>lighty-rcgnmi-app-module</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>

<name>${project.groupId}:${project.artifactId}</name>
<url>https://github.com/PANTHEONtech/lighty</url>
Expand Down
4 changes: 2 additions & 2 deletions lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-app-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../../../lighty-core/lighty-app-parent/pom.xml</relativePath>
</parent>

<groupId>io.lighty.applications.rcgnmi</groupId>
<artifactId>lighty-rcgnmi-app</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>

<name>${project.groupId}:${project.artifactId}</name>
<url>https://github.com/PANTHEONtech/lighty</url>
Expand Down
2 changes: 1 addition & 1 deletion lighty-applications/lighty-rcgnmi-app-aggregator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<groupId>io.lighty.applications.rcgnmi</groupId>
<artifactId>lighty-rcgnmi-app-aggregator</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<packaging>pom</packaging>

<properties>
Expand Down
5 changes: 2 additions & 3 deletions lighty-applications/lighty-rnc-app-aggregator/lighty-rnc-app-docker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<groupId>io.lighty.applications.rnc</groupId>
<artifactId>lighty-rnc-app-docker</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>

<properties>
<image.name>lighty-rnc</image.name>
Expand Down Expand Up @@ -78,8 +78,7 @@
<phase>prepare-package</phase>
<configuration>
<target>
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's recommended to keep attributes of XML tags on separate lines, especially for long lines like this one. This makes the code easier to read and understand.

                                <unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}"
                                       dest="${basedir}/target/docker-stage" />

</target>
</configuration>
<goals>
Expand Down
4 changes: 2 additions & 2 deletions lighty-applications/lighty-rnc-app-aggregator/lighty-rnc-app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-app-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../../../lighty-core/lighty-app-parent/pom.xml</relativePath>
</parent>

<groupId>io.lighty.applications.rnc</groupId>
<artifactId>lighty-rnc-app</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>${project.groupId}:${project.artifactId}</name>
Expand Down
4 changes: 2 additions & 2 deletions lighty-applications/lighty-rnc-app-aggregator/lighty-rnc-module/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../../../lighty-core/lighty-parent/pom.xml</relativePath>
</parent>

<groupId>io.lighty.applications.rnc</groupId>
<artifactId>lighty-rnc-module</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>

<name>${project.groupId}:${project.artifactId}</name>
<url>https://github.com/PANTHEONtech/lighty</url>
Expand Down
2 changes: 1 addition & 1 deletion lighty-applications/lighty-rnc-app-aggregator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<groupId>io.lighty.applications.rnc</groupId>
<artifactId>lighty-rnc-aggregator</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<packaging>pom</packaging>

<properties>
Expand Down
2 changes: 1 addition & 1 deletion lighty-applications/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<groupId>io.lighty.applications</groupId>
<artifactId>lighty-applications-aggregator</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<packaging>pom</packaging>

<properties>
Expand Down
2 changes: 1 addition & 1 deletion lighty-core/dependency-versions/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>io.lighty.core</groupId>
<artifactId>dependency-versions</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<packaging>pom</packaging>

<name>${project.groupId}:${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion lighty-core/lighty-app-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../lighty-parent/pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion lighty-core/lighty-binding-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<parent>
<groupId>io.lighty.core</groupId>
<artifactId>lighty-parent</artifactId>
<version>21.3.0-SNAPSHOT</version>
<version>21.4.0-SNAPSHOT</version>
<relativePath>../lighty-parent/pom.xml</relativePath>
</parent>

Expand Down
Loading
Loading