WIP 3d #1100

PhilipDeegan · 2025-11-05T12:13:44Z

not ready, just here for TC tests

coderabbitai · 2025-11-05T12:13:54Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

+
+#include "core/def/phare_mpi.hpp"
+
+#include "test_diagnostics.ipp"


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp

                auto& J  = hybridModel.state.J;
                auto& Vi = hybridModel.state.ions.velocity();
                auto& Ni = hybridModel.state.ions.chargeDensity();
+                auto& E  = hybridModel.state.electromag.E;


src/amr/data/particles/refine/splitter.hpp

        using FineParticle = decltype(particles[0]); // may be a reference

        core::apply(patterns, [&](auto const& pattern) {
+            auto weight = static_cast<Weight_t>(pattern.weight_);


tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                        return std::make_tuple(criter_x, criter_y, criter_z);
+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/core/numerics/pusher/fusher.hpp

+// #include "core/utilities/range/range.hpp"
+// #include "core/data/particles/particle.hpp"


src/core/numerics/pusher/fusher.hpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/core/data/grid/gridlayout.hpp

pyphare/pyphare/pharesee/hierarchy/hierarchy_utils.py


+def diff_hierarchy(hier):
+    import pyphare.core.box as boxm
+    from pyphare.pharesee.geometry import hierarchy_overlaps


pyphare/pyphare/pharesee/geometry.py

                    )

-    def append(ref_pd, cmp_pd, refPatch, cmpPatch, overlap, offset_tuple):
+    def append(name, ref_pd, cmp_pd, refPatch, cmpPatch, overlap, offset_tuple):


pyphare/pyphare/pharesee/geometry.py

+        gbox = boxm.grow(patch.box, [1]*dim)
+        return gbox * domain_box != gbox
+
+    border_patches = [patch for patch in patches if is_border_patch(patch)]


pyphare/pyphare/pharesee/geometry.py

+    # def borders_per(patch):
+    #     return "".join(


pyphare/pyphare/pharesee/geometry.py

+    # if dim == 1 and len(patches) > 0:
+    #     patches = [patches[0], patches[-1]]
+
+    # # filter out patches not near a border


pyphare/pyphare/pharesee/geometry.py

+    # for patch_i, ref_patch in enumerate(border_patches):
+    #     in_sides = "".join(borders_per_patch[ref_patch])
+    #     assert in_sides in shifts, f"{in_sides} not found"
+
+    #     for ref_pdname, ref_pd in ref_patch.patch_datas.items():
+    #         for shift in shifts[in_sides]:
+    #             for cmp_patch in border_patches[
+    #                 patch_i:


pyphare/pyphare/pharesee/geometry.py

+    #                 for cmp_pdname, cmp_pd in cmp_patch.patch_datas.items():
+    #                     if cmp_pdname == ref_pdname:
+    #                         gb1 = ref_pd.ghost_box
+    #                         gb2 = cmp_pd.ghost_box
+
+    #                         offset = np.asarray(shift)
+    #                         overlap = gb1 * boxm.shift(gb2, -offset)
+
+    #                         if overlap is not None:
+    #                             other_ovrlp = boxm.shift(gb1, offset) * gb2
+    #                             assert other_ovrlp is not None
+
+    #                             if ref_pd.quantity == "field":
+    #                                 overlap = toFieldBox(overlap, ref_pd)
+    #                                 other_ovrlp = toFieldBox(other_ovrlp, ref_pd)
+
+    #                             append(
+    #                                 ref_pdname,
+    #                                 ref_pd,
+    #                                 cmp_pd,
+    #                                 ref_patch,
+    #                                 cmp_patch,
+    #                                 overlap,
+    #                                 (zero_offset, (-offset).tolist()),


pyphare/pyphare/pharesee/geometry.py

pyphare/pyphare/pharesee/phare_vtk/plot.py

+#
+
+
+from .base import *


pyphare/pyphare/pharesee/phare_vtk/show.py

+#
+#
+
+from .base import *


pyphare/pyphare/pharesee/phare_vtk/plot.py

+#
+
+
+from .base import *


pyphare/pyphare/pharesee/phare_vtk/show.py

+#
+#
+
+from .base import *


PhilipDeegan marked this pull request as draft November 5, 2025 12:13

github-advanced-security bot found potential problems Nov 5, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from e1b7238 to 4de43d2 Compare November 7, 2025 15:11

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Outdated

Comment on lines 9 to 10

// #include "core/utilities/range/range.hpp"

// #include "core/data/particles/particle.hpp"

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Fixed Show fixed Hide fixed

PhilipDeegan force-pushed the 3d_new branch from 4de43d2 to f525884 Compare November 7, 2025 21:20

PhilipDeegan mentioned this pull request Nov 8, 2025

Update to 3D #960

Draft

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from 08883a9 to d04e167 Compare November 10, 2025 12:55

github-advanced-security bot found potential problems Nov 10, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 14 times, most recently from 76f6bfb to be02045 Compare November 11, 2025 16:42

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Dec 9, 2025

View reviewed changes

github-advanced-security bot found potential problems Dec 10, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 3 times, most recently from b7a0411 to 018c485 Compare December 10, 2025 12:43

🐰

c6cbda7

PhilipDeegan force-pushed the 3d_new branch 4 times, most recently from ce74608 to 211e0e4 Compare December 15, 2025 23:34

PhilipDeegan added 14 commits January 5, 2026 11:03

vtkhdf

4d60ba6

wippolatta

c9ac422

betterment

b7c48aa

rebase from 3d, fix offsets

cb4e001

multi model support for vtk

aa3f573

Take max of ions border overlaps after compute

e9b5abe

advanced restart options

724967b

fix maxwellian init validation in python

d0249ac

vtkhdf

13030a4

3d

ea49b96

min patch size 6 in interp 1

0b4d1aa

mpidbg

28c06cb

++

1c82964

++

52e43b9

PhilipDeegan force-pushed the 3d_new branch from 04a9ed9 to 52e43b9 Compare January 5, 2026 10:12

PhilipDeegan mentioned this pull request Jan 5, 2026

generalized overlap number verification #406

Open

vtk pngs

3ae2bee

github-advanced-security bot found potential problems Jan 6, 2026

View reviewed changes


		#include "core/def/phare_mpi.hpp"

		#include "test_diagnostics.ipp"

		// #include "core/utilities/range/range.hpp"
		// #include "core/data/particles/particle.hpp"

WIP 3d #1100

Are you sure you want to change the base?

WIP 3d #1100

Uh oh!

Conversation

PhilipDeegan commented Nov 5, 2025

Uh oh!

coderabbitai bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Uh oh!

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Nov 5, 2025 •

edited

Loading