Skip to content

Powerpoint2007 reader: Added support for loading text run without properties #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Powerpoint2007 reader: Added support for loading text run without properties #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19ea091
Added support for loading text run without properties
Jun 12, 2025
a9df0c3
Merge branch 'PHPOffice:master' into powerpoint2007-text-run-without-…
Wilkolicious Oct 27, 2025
9a29a9b
Updated changelog
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changes/1.3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

## Enhancements
- `phpoffice/phpspreadsheet`: Allow version 5.0 by [@seanlynchwv](http://github.com/seanlynchwv) in [#879](https://github.com/PHPOffice/PHPPresentation/pull/879)
- PowerPoint2007 Reader: Added support for loading text run without properties by [@Wilkolicious](http://github.com/Wilkolicious) in [#871](https://github.com/PHPOffice/PHPPresentation/pull/871)

## Bug fixes

9 changes: 4 additions & 5 deletions src/PhpPresentation/Reader/PowerPoint2007.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,9 +1511,9 @@ protected function loadParagraph(XMLReader $document, DOMElement $oElement, $oSh
}
if ('a:r' == $oSubElement->tagName) {
$oElementrPr = $document->getElement('a:rPr', $oSubElement);
if (is_object($oElementrPr)) {
$oText = $oParagraph->createTextRun();

$oText = $oParagraph->createTextRun();
if (is_object($oElementrPr)) {
if ($oElementrPr->hasAttribute('b')) {
$att = $oElementrPr->getAttribute('b');
$oText->getFont()->setBold('true' == $att || '1' == $att ? true : false);
Expand Down Expand Up @@ -1591,10 +1591,9 @@ protected function loadParagraph(XMLReader $document, DOMElement $oElement, $oSh
$oText->getFont()->setCharset((int) $oElementFont->getAttribute('charset'));
}
}

$oSubSubElement = $document->getElement('a:t', $oSubElement);
$oText->setText($oSubSubElement->nodeValue);
}
$oSubSubElement = $document->getElement('a:t', $oSubElement);
$oText->setText($oSubSubElement->nodeValue);
}
}
}
Expand Down