-
Notifications
You must be signed in to change notification settings - Fork 534
Added setFirstSliceAngle to Doughnut Chart #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Sorry did not mean to create a PR here which happened automatically when I created a PR on my copy of the repo. Will try to submit a PR later if I can get the doughnut rotation working as expected |
Co-authored-by: Progi1984 <[email protected]>
Hey @Progi1984 thanks for reviewing this PR! If you can merge this I can follow up with another one to change the corner radius on roundedRect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add unit tests for Doughnut Class ?
Description
We needed the ability to create a half circle from 270' to 90' but it was not working
This is now fixed by adding a new
->setFirstSliceAngle( int );
helper to Doughnut.phpPreviously this was hard-coded to 0. Over-writing this did not work as
<c:view3D>
was imported into every chart which was conflicting with the rule.After debugging the output from powerpoint itself, I learned that we can fix this by making
<c:view3D>
conditional. Now making programatic changes to 2d charts works as expected.It now works:
Fixes # (issue)
Checklist: