-
Notifications
You must be signed in to change notification settings - Fork 1
🎉 Pipeline formalization, including scikit-learn block wrappers #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review these changes at https://app.gitnotebooks.com/PLAID-lib/plaid/pull/101 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@xroynard This PR contains additions in the dataset class (mainly a mechanism for calling slices of dataset, returning a dataset), and a first example of scikit-learn pipeline acting directly on plaid objects, in the examples/pipelines folder. To me, even if we change the design later, we can merge this PR for the modifications of datasets and since the pipeline are proposed as examples for the moment. edit: still working on it, marked as draft |
…e arg in PCAEmbeddingNode
…ing a global dict and specifying only arguments to be optimized by GridSearchCV (n_components of PCA for the moment)
…ents specified in config.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the full knowledge to be able to properly review so I'm just dropping a few comments for stuff outisde the examples/ folder
…GNS_FIELD_LOCATIONS
…meters and factorize FeatureIdentifier typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🔥 Just a few last minor comments, approving anyways
✨ Summary
This PR introduces significant improvements toward standardizing pipelines for the PLAID dataset, with a design that aligns closely with the scikit-learn API wherever applicable. It includes:
Sample
andDataset
classes to support these new features and ensure compatibility with the standardized pipeline interfaceThese changes pave the way for more modular, reusable, and interoperable components when building ML workflows on PLAID.