-
Notifications
You must be signed in to change notification settings - Fork 1
🎉 feat(sample.py) add option to overwrite folder in save #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review these changes at https://app.gitnotebooks.com/PLAID-lib/plaid/pull/130 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could switch to pathlib
like in other parts of the library
+1 pathlib makes code more easily readable most of the time |
We could then remove any reference to |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! (I cannot approve since I initiated the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Usefull to have the option to overwrite samples