Skip to content

🎉 feat(sample.py) add option to overwrite folder in save #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025

Conversation

casenave
Copy link
Member

@casenave casenave commented Aug 8, 2025

Usefull to have the option to overwrite samples

@casenave casenave requested a review from a team as a code owner August 8, 2025 07:51
Copy link

gitnotebooks bot commented Aug 8, 2025

Review these changes at https://app.gitnotebooks.com/PLAID-lib/plaid/pull/130

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave casenave added this to the version 0.1.7 milestone Aug 9, 2025
Copy link
Contributor

@bstaber bstaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could switch to pathlib like in other parts of the library

@xroynard
Copy link
Contributor

We could switch to pathlib like in other parts of the library

+1

pathlib makes code more easily readable most of the time

https://docs.python.org/3/library/pathlib.html

@xroynard
Copy link
Contributor

We could then remove any reference to os, except for some os.system('...') calls (which might be replaced by subprocess but this is another problem)

@xroynard xroynard self-assigned this Aug 12, 2025
@xroynard xroynard requested a review from bstaber August 12, 2025 14:19
@xroynard
Copy link
Contributor

We could switch to pathlib like in other parts of the library

done

Copy link
Member Author

@casenave casenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! (I cannot approve since I initiated the PR)

Copy link
Contributor

@xroynard xroynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casenave casenave merged commit a549e22 into main Aug 12, 2025
24 checks passed
@casenave casenave deleted the sample_save_overwrite branch August 12, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants